Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metadata): add method to access metadata #2143

Merged
merged 9 commits into from
Jun 17, 2023

Conversation

matthewmayer
Copy link
Contributor

fix #1984

@matthewmayer matthewmayer requested a review from a team as a code owner May 9, 2023 06:23
@matthewmayer matthewmayer self-assigned this May 9, 2023
@matthewmayer matthewmayer added c: feature Request for new feature p: 1-normal Nothing urgent c: locale Permutes locale definitions labels May 9, 2023
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #2143 (11121d8) into next (19635a7) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2143      +/-   ##
==========================================
- Coverage   99.59%   99.59%   -0.01%     
==========================================
  Files        2623     2623              
  Lines      245491   245504      +13     
  Branches     1149     1152       +3     
==========================================
+ Hits       244503   244514      +11     
- Misses        961      963       +2     
  Partials       27       27              
Impacted Files Coverage Δ
src/faker.ts 92.05% <100.00%> (+0.19%) ⬆️

... and 2 files with indirect coverage changes

src/faker.ts Outdated Show resolved Hide resolved
src/faker.ts Outdated Show resolved Hide resolved
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
src/faker.ts Show resolved Hide resolved
ST-DDT
ST-DDT previously approved these changes May 10, 2023
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit conflicted about why we extract the metaobject access from the definitions. Currently, you can access them fine just fine via faker.definitions.metadata. What is the benefit of the implementation of this PR?

src/faker.ts Outdated Show resolved Hide resolved
src/faker.ts Outdated Show resolved Hide resolved
@matthewmayer
Copy link
Contributor Author

I'm a bit conflicted about why we extract the metaobject access from the definitions. Currently, you can access them fine just fine via faker.definitions.metadata. What is the benefit of the implementation of this PR?

  1. its not documented
  2. we want the freedom to be able to rearrange things within definitions without it being a breaking change.

matthewmayer and others added 2 commits May 14, 2023 17:55
Co-authored-by: DivisionByZero <leyla.jaehnig@gmx.de>
@ST-DDT ST-DDT requested review from a team May 24, 2023 20:39
@Shinigami92 Shinigami92 added the do NOT merge yet Do not merge this PR into the target branch yet label May 24, 2023
@Shinigami92
Copy link
Member

Do not merge yet, so we can release a v8.0.2 the next few days
Generally do not merge feat+ into next, only fix, chore, test and docs

@Shinigami92 Shinigami92 removed the do NOT merge yet Do not merge this PR into the target branch yet label May 28, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) June 17, 2023 06:14
@ST-DDT ST-DDT merged commit fd8cfe5 into faker-js:next Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add method to access the locale metadata
4 participants