-
-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metadata): add method to access metadata #2143
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2143 +/- ##
==========================================
- Coverage 99.59% 99.59% -0.01%
==========================================
Files 2623 2623
Lines 245491 245504 +13
Branches 1149 1152 +3
==========================================
+ Hits 244503 244514 +11
- Misses 961 963 +2
Partials 27 27
|
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit conflicted about why we extract the metaobject access from the definitions. Currently, you can access them fine just fine via faker.definitions.metadata
. What is the benefit of the implementation of this PR?
|
Co-authored-by: DivisionByZero <leyla.jaehnig@gmx.de>
Do not merge yet, so we can release a v8.0.2 the next few days |
fix #1984