Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locale): invalid date definitions #2293

Merged
merged 3 commits into from
Aug 6, 2023

Conversation

xDivisionByZerox
Copy link
Member

Precondition for #2265.

Fixes invalid locale entries for DateDefinitions which have previously been casted to ignore the TypeScript compiler error.

@xDivisionByZerox xDivisionByZerox added c: bug Something isn't working p: 1-normal Nothing urgent c: locale Permutes locale definitions m: date Something is referring to the date module labels Aug 5, 2023
@xDivisionByZerox xDivisionByZerox requested a review from a team August 5, 2023 23:44
@xDivisionByZerox xDivisionByZerox self-assigned this Aug 5, 2023
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner August 5, 2023 23:44
@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #2293 (7dcdf04) into next (527d357) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2293      +/-   ##
==========================================
- Coverage   99.60%   99.60%   -0.01%     
==========================================
  Files        2644     2644              
  Lines      245775   245772       -3     
  Branches     1082     1082              
==========================================
- Hits       244799   244793       -6     
- Misses        949      952       +3     
  Partials       27       27              
Files Changed Coverage Δ
src/locales/ar/date/weekday.ts 100.00% <100.00%> (ø)
src/locales/ur/date/month.ts 100.00% <100.00%> (ø)
src/locales/ur/date/weekday.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT requested a review from a team August 6, 2023 10:16
@xDivisionByZerox xDivisionByZerox merged commit 3cecae9 into next Aug 6, 2023
@xDivisionByZerox xDivisionByZerox deleted the fix/locale/invalid-date-entries branch August 6, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working c: locale Permutes locale definitions m: date Something is referring to the date module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants