feat(locale): improve persons and locations for zh_CN

[CoolPlayLin]

Works

• add two email addresses
• fix the name of China states
• add a lot of names, first name and last names

[codecov]

Codecov Report

Merging #2318 (20f66bf) into next (466b804) will increase coverage by 0.00%.
Report is 1 commits behind head on next.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff            @@
##             next    #2318    +/-   ##
========================================
  Coverage   99.60%   99.60%            
========================================
  Files        2735     2735            
  Lines      248991   249961   +970     
  Branches     1078     1082     +4     
========================================
+ Hits       247998   248985   +987     
+ Misses        966      949    -17     
  Partials       27       27            

Files Changed	Coverage Δ
src/locales/zh_CN/internet/free_email.ts	100.00% <100.00%> (ø)
src/locales/zh_CN/location/state.ts	100.00% <100.00%> (ø)
src/locales/zh_CN/location/state_abbr.ts	100.00% <100.00%> (ø)
src/locales/zh_CN/person/female_first_name.ts	100.00% <100.00%> (ø)
src/locales/zh_CN/person/first_name.ts	100.00% <100.00%> (ø)
src/locales/zh_CN/person/last_name.ts	100.00% <100.00%> (ø)
src/locales/zh_CN/person/male_first_name.ts	100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

[CoolPlayLin]

@matthewmayer

[CoolPlayLin]

@ST-DDT

[CoolPlayLin]

[CoolPlayLin]

@matthewmayer

[ST-DDT]

@import-brain @matthewmayer Could you please summarize what needs to be discussed here exactly?
Otherwise it is very hard to find in the resolved review comments.

[import-brain]

@import-brain @matthewmayer Could you please summarize what needs to be discussed here exactly? Otherwise it is very hard to find in the resolved review comments.

For province names in Chinese, there are multiple ways to write them--- 广西壮族自治区 (full formal name) or 广西 (commonly used name) or 桂 (one character abbreviation). I wanted to discuss how we should allocate these names between state and stateAbbr in the Chinese locale. The full formal name isn't commonly used, so I was thinking we could have the commonly used names in state and the one character abbreviations in stateAbbr, what do you think?

[CoolPlayLin]

@import-brain The full name of province is really common in address. In address, it should more detailed. But I think we the 广西 is better than 桂. The abbr with two character is more known in China. This is because some of province even have more than one official abbr with one character. For instance, 云南省(Yunnan Province) could call abbr with one character as 云 or 滇. If we use such abbr, it would cause more issue and trouble need to resolve.
All in all, I recommand not use abbr with one character or come up with a way to resolve it.
CC@matthewmayer @ST-DDT

[matthewmayer]

Right

Option A is "formal name in state, common name in stateAbbr"

Option B is "common name in state, one character name in stateAbbr"

Option C would be modifying the methods to allow for three different possible values.

[CoolPlayLin]

IMO, If it would use for generate address , it must use full name of province

CC @matthewmayer @ST-DDT @import-brain

[ST-DDT]

Team notice

We are currently internally investigating the possibilities.

[ST-DDT]

Team decision

Short term (now):

We will use the full name for state and the common name for state_abbr

Long term (v9):

We will change the state method to return a complex object: { fullName, commonName, abbreviation } and let the user take one of those or whatever is there.

[matthewmayer]

@CoolPlayLin please modify the state and state_abbr definitions so state returns the official name e.g. '广西壮族自治区', and state_abbr returns the short name '广西'. The one-character abbrevations like 桂 will no longer be used.

outdated