Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(locale): add hacker for zh_CN #2337

Merged
merged 7 commits into from
Sep 3, 2023
Merged

feat(locale): add hacker for zh_CN #2337

merged 7 commits into from
Sep 3, 2023

Conversation

CoolPlayLin
Copy link
Contributor

Works

  • Add hacker module

@CoolPlayLin CoolPlayLin requested a review from a team as a code owner August 23, 2023 04:29
@CoolPlayLin CoolPlayLin changed the title feat(locale): Add more module for zh_CN feat(locale): Add more module for zh_CN - 2 Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023 •
edited
Loading

Codecov Report

Merging #2337 (95a80aa) into next (76886ad) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2337      +/-   ##
==========================================
- Coverage   99.61%   99.61%   -0.01%     
==========================================
  Files        2769     2774       +5     
  Lines      251668   251763      +95     
  Branches     1085     1083       -2     
==========================================
+ Hits       250692   250786      +94     
- Misses        949      950       +1     
  Partials       27       27
Files Changed Coverage Δ
src/locales/zh_CN/hacker/adjective.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/hacker/index.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/hacker/noun.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/hacker/phrase.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/hacker/verb.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@CoolPlayLin CoolPlayLin changed the title feat(locale): Add more module for zh_CN - 2 feat(locale): add hacker for zh_CN Aug 23, 2023
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: hacker Something is referring to the hacker module labels Aug 26, 2023
@ST-DDT ST-DDT requested review from a team August 27, 2023 20:28
@CoolPlayLin CoolPlayLin removed their assignment Sep 1, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) September 3, 2023 16:43
@ST-DDT ST-DDT merged commit 9176fcb into faker-js:next Sep 3, 2023
@CoolPlayLin CoolPlayLin deleted the module_zh_CN-2 branch September 8, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@import-brain import-brain import-brain approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees
No one assigned
Labels
c: locale Permutes locale definitions m: hacker Something is referring to the hacker module p: 1-normal Nothing urgent
Projects
None yet
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.
3 participants
@CoolPlayLin @ST-DDT @import-brain