Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(locale): add yo locale, start with person #2363

Merged
merged 11 commits into from
Sep 3, 2023
Merged

feat(locale): add yo locale, start with person #2363

merged 11 commits into from
Sep 3, 2023

Conversation

mrsimi
Copy link
Contributor

@mrsimi mrsimi commented Aug 31, 2023 •
edited
Loading

@mrsimi mrsimi requested a review from a team August 31, 2023 22:19
@mrsimi mrsimi requested a review from a team as a code owner August 31, 2023 22:19
@codecov
Copy link

codecov bot commented Sep 1, 2023 •
edited
Loading

Codecov Report

Merging #2363 (788ba85) into next (6bb4775) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff            @@
##             next    #2363    +/-   ##
========================================
  Coverage   99.60%   99.61%            
========================================
  Files        2760     2769     +9     
  Lines      251266   251668   +402     
  Branches     1085     1085            
========================================
+ Hits       250276   250696   +420     
+ Misses        963      945    -18     
  Partials       27       27
Files Changed Coverage Δ
src/locale/index.ts 100.00% <100.00%> (ø)
src/locale/yo_NG.ts 100.00% <100.00%> (ø)
src/locales/index.ts 100.00% <100.00%> (ø)
src/locales/yo_NG/index.ts 100.00% <100.00%> (ø)
src/locales/yo_NG/metadata.ts 100.00% <100.00%> (ø)
src/locales/yo_NG/person/female_first_name.ts 100.00% <100.00%> (ø)
src/locales/yo_NG/person/first_name.ts 100.00% <100.00%> (ø)
src/locales/yo_NG/person/index.ts 100.00% <100.00%> (ø)
src/locales/yo_NG/person/last_name.ts 100.00% <100.00%> (ø)
src/locales/yo_NG/person/last_name_pattern.ts 100.00% <100.00%> (ø)
... and 1 more

... and 2 files with indirect coverage changes

@matthewmayer matthewmayer linked an issue Sep 1, 2023 that may be closed by this pull request
Add the Yoruba Language (yo_NG) as a new locale #2341
Closed
@matthewmayer matthewmayer added c: feature Request for new feature p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Sep 1, 2023
matthewmayer
matthewmayer requested changes Sep 1, 2023
View reviewed changes
src/locales/yo/person/first_name.ts Outdated Show resolved Hide resolved
src/locales/yo/person/female_first_name.ts Outdated Show resolved Hide resolved
matthewmayer
matthewmayer requested changes Sep 1, 2023
View reviewed changes
src/locales/yo/index.ts Outdated Show resolved Hide resolved
@matthewmayer matthewmayer mentioned this pull request Sep 1, 2023
Closed
ST-DDT
ST-DDT previously approved these changes Sep 1, 2023
View reviewed changes
@ST-DDT ST-DDT requested review from a team September 1, 2023 11:47
matthewmayer
matthewmayer requested changes Sep 1, 2023
View reviewed changes
src/locales/yo_NG/metadata.ts Outdated Show resolved Hide resolved
matthewmayer
matthewmayer previously approved these changes Sep 1, 2023
View reviewed changes
@ST-DDT ST-DDT requested review from matthewmayer and a team September 1, 2023 20:57
@ST-DDT ST-DDT enabled auto-merge (squash) September 3, 2023 06:51
@ST-DDT ST-DDT merged commit 76886ad into faker-js:next Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@import-brain import-brain import-brain approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@matthewmayer matthewmayer matthewmayer approved these changes

Assignees

@mrsimi mrsimi

Labels
c: feature Request for new feature c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
None yet
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

Add the Yoruba Language (yo_NG) as a new locale
4 participants
@mrsimi @matthewmayer @ST-DDT @import-brain