fix(date): ensures correct range for birthdate

[mumumilk]

fixes #2534

[codecov]

Codecov Report

Merging #2535 (e700a61) into next (ef965da) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #2535      +/-   ##
==========================================
- Coverage   99.58%   99.58%   -0.01%     
==========================================
  Files        2801     2801              
  Lines      249842   249842              
  Branches     1085     1082       -3     
==========================================
- Hits       248797   248793       -4     
- Misses       1017     1021       +4     
  Partials       28       28              

Files	Coverage Δ
src/modules/date/index.ts	100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

[ST-DDT]

Please add these tests:

faker/test/modules/date.spec.ts

Lines 576 to 603 in 022fa54

	it('returns a random birthdate that is 18+ by default', () => {
	// Generate the latest possible value => youngest
	faker.seed(2855577693);
	const refDate = new Date();
	const birthdate = faker.date.birthdate({ refDate });
	expect(birthdate).toBeInstanceOf(Date);
	const value = birthdate.valueOf();
	const refDateValue = refDate.valueOf();
	expect(value).toBeLessThanOrEqual(refDateValue);
	const deltaDate = new Date(refDateValue - value);
	expect(deltaDate.getUTCFullYear() - 1970).toBeGreaterThanOrEqual(18);
	});
	it('returns a random birthdate in one year', () => {
	const min = 1990;
	const max = 1990;
	const birthdate = faker.date.birthdate({ min, max, mode: 'year' });
	// birthdate is a date object
	expect(birthdate).toBeInstanceOf(Date);
	expect(birthdate.toISOString()).not.toMatch(/T00:00:00.000Z/);
	// Generated date is between min and max
	expect(birthdate.getUTCFullYear()).toBeGreaterThanOrEqual(min);
	expect(birthdate.getUTCFullYear()).toBeLessThanOrEqual(max);
	});