Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support const modifier on type parameters #2679

Closed
Shinigami92 opened this issue Feb 22, 2024 · 1 comment · Fixed by #2685
Closed

Support const modifier on type parameters #2679

Shinigami92 opened this issue Feb 22, 2024 · 1 comment · Fixed by #2685
Assignees
Labels
breaking change Cannot be merged when next version is not a major release c: feature Request for new feature p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone

Comments

@Shinigami92
Copy link
Member

Clear and concise description of the problem

As a developer using faker I want to benefit from const modifier on type parameters so that I don't need to explicitly add as const.

Suggested solution

Add const modifier on type parameters.

Alternative

No response

Additional context

This feature was introduced by TypeScript v5.0.0 and would break TypeScript support < v5

@Shinigami92 Shinigami92 added c: feature Request for new feature s: pending triage Pending Triage s: waiting for user interest Waiting for more users interested in this feature labels Feb 22, 2024
@Shinigami92 Shinigami92 added this to the v9.0 milestone Feb 22, 2024
Copy link
Contributor

Thank you for your feature proposal.

We marked it as "waiting for user interest" for now to gather some feedback from our community:

  • If you would like to see this feature be implemented, please react to the description with an up-vote (:+1:).
  • If you have a suggestion or want to point out some special cases that need to be considered, please leave a comment, so we are aware about them.

We would also like to hear about other community members' use cases for the feature to give us a better understanding of their potential implicit or explicit requirements.

We will start the implementation based on:

  • the number of votes (:+1:) and comments
  • the relevance for the ecosystem
  • availability of alternatives and workarounds
  • and the complexity of the requested feature

We do this because:

  • There are plenty of languages/countries out there and we would like to ensure that every method can cover all or almost all of them.
  • Every feature we add to faker has "costs" associated to it:
    • initial costs: design, implementation, reviews, documentation
    • running costs: awareness of the feature itself, more complex module structure, increased bundle size, more work during refactors

View more issues which are waiting for user interest

@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug breaking change Cannot be merged when next version is not a major release and removed s: pending triage Pending Triage s: waiting for user interest Waiting for more users interested in this feature labels Feb 22, 2024
@ST-DDT ST-DDT self-assigned this Feb 25, 2024
@ST-DDT ST-DDT linked a pull request Feb 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Cannot be merged when next version is not a major release c: feature Request for new feature p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants