Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic npm publish on commit #268

Open
Ranguna opened this issue Jan 23, 2022 · 6 comments
Open

Automatic npm publish on commit #268

Ranguna opened this issue Jan 23, 2022 · 6 comments
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent s: waiting for user interest Waiting for more users interested in this feature
Milestone

Comments

@Ranguna
Copy link

Ranguna commented Jan 23, 2022

Clear and concise description of the problem

As a developer using faker I want to get the latest merged changes on npm so that I can get access to the latest changes without local npm linking.

Right now, it seems that tag creation is done manually (maybe?) and there are some changes that are not available on the published npm version.

Suggested solution

We could setup some action to execute on master commits to automatically bump versions and publish to npm.

I've used https://www.npmjs.com/package/semantic-release in the past, config is a bit daunting but the result is pretty great.

Additional branches could be created to generate release candidate/alpha/beta releases as well (but personally, I don't really think this is useful).

Alternative

An alternative would be to keep pushing tags manually but maybe do it at a higher frequency ?

Additional context

No response

@Ranguna Ranguna added the s: pending triage Pending Triage label Jan 23, 2022
@Shinigami92
Copy link
Member

I think https://github.com/typescript-eslint/typescript-eslint has something like that.
Definitely not real releases on commits, but something like commit / nightly builds would be cool.

Currently we are awaiting #254 and #257, so a release would make no sense anyways.
We hope that we can do that in a few days.
Sorry that we are kinda blocked so long, we working hard on making the base stable and newly organized. (See name of milestone v6.0.0)

@prisis
Copy link
Member

prisis commented Jan 23, 2022

I have a package that is doing auto release its based on semantic-release (https://github.com/anolilab/javascript-style-guide/tree/main/packages/semantic-release-preset), we (maintainer) just need to talk how we will handle it.

And for the first part that we don't release so fast is, because we doing it in our free time, we always open for help and in the end nobody wants to have a broken release ;)

@import-brain import-brain added c: feature Request for new feature and removed s: pending triage Pending Triage labels Jan 23, 2022
@Ranguna
Copy link
Author

Ranguna commented Jan 25, 2022

Sorry that we are kinda blocked so long, we working hard on making the base stable and newly organized.

Not at all, I'll patiently wait!
Thanks for the awesome work!

And for the first part that we don't release so fast is, because we doing it in our free time

100% completely understandable!

nobody wants to have a broken release ;)

Automated tests are not always the answer, but in this case, I think they'd really help preventing the possibility of a broken releases vs having manual human review of releases (maybe the time is better spent on PR review). But maybe I'm missing an important detail here, since I haven't been involved a lot on the community development of this lib.

Also, not saying that it would be good to have this now. Since there are still things that need to be fleshed out for this initial release, but maybe having this in the future once things are running smooth would be cool.

I might try a PR for this. Albeit you'll need to be patient because my past experience is only with gitlab ci 😋

@Shinigami92
Copy link
Member

After yesterdays incident, I would love to have a publish on "create git tag"-event
That would let me sleep for two more hours...

@ST-DDT ST-DDT added p: 2-high Fix main branch and removed p: 1-normal Nothing urgent labels Mar 29, 2022
@Shinigami92 Shinigami92 added c: infra Changes to our infrastructure or project setup and removed c: feature Request for new feature labels Aug 12, 2022
@Shinigami92 Shinigami92 moved this from Todo to In Progress in Faker Roadmap Aug 12, 2022
@Shinigami92 Shinigami92 linked a pull request Aug 12, 2022 that will close this issue
@ST-DDT ST-DDT added the s: on hold Blocked by something or frozen to avoid conflicts label Sep 8, 2022
@ST-DDT ST-DDT modified the milestones: v7 - Current Major, vFuture Sep 8, 2022
@ST-DDT ST-DDT moved this from In Progress to Todo in Faker Roadmap Sep 8, 2022
@xDivisionByZerox
Copy link
Member

This is blocked by #757. We first need a general auto-publish script before publishing each build version,

@ST-DDT ST-DDT removed s: on hold Blocked by something or frozen to avoid conflicts p: 2-high Fix main branch labels Nov 21, 2023
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: waiting for user interest Waiting for more users interested in this feature labels Nov 21, 2023
Copy link
Contributor

Thank you for your feature proposal.

We marked it as "waiting for user interest" for now to gather some feedback from our community:

  • If you would like to see this feature be implemented, please react to the description with an up-vote (:+1:).
  • If you have a suggestion or want to point out some special cases that need to be considered, please leave a comment, so we are aware about them.

We would also like to hear about other community members' use cases for the feature to give us a better understanding of their potential implicit or explicit requirements.

We will start the implementation based on:

  • the number of votes (:+1:) and comments
  • the relevance for the ecosystem
  • availability of alternatives and workarounds
  • and the complexity of the requested feature

We do this because:

  • There are plenty of languages/countries out there and we would like to ensure that every method can cover all or almost all of them.
  • Every feature we add to faker has "costs" associated to it:
    • initial costs: design, implementation, reviews, documentation
    • running costs: awareness of the feature itself, more complex module structure, increased bundle size, more work during refactors

View more issues which are waiting for user interest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent s: waiting for user interest Waiting for more users interested in this feature
Projects
No open projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

6 participants