Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special characters in email #272

Closed
pkuczynski opened this issue Jan 23, 2022 · 1 comment · Fixed by #792
Closed

Special characters in email #272

pkuczynski opened this issue Jan 23, 2022 · 1 comment · Fixed by #792
Assignees
@harsohailB
Labels
c: feature Request for new feature p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone
v6.2 - New small ...

Comments

@pkuczynski
Copy link
Member

Clear and concise description of the problem

Email addresses can contain special characters like !#$%&'*+-/=?^_{|}~` (see https://stackoverflow.com/a/2049510/1806316). Faker could support this (maybe with an option?), so generated data is more realistic...

Suggested solution

Update faker.internet.email method.

Alternative

No response

Additional context

No response
@pkuczynski pkuczynski added the s: pending triage Pending Triage label Jan 23, 2022
@import-brain import-brain added c: feature Request for new feature p: 1-normal Nothing urgent and removed s: pending triage Pending Triage labels Jan 23, 2022
@prisis prisis added this to the v6.1.0 - First new features milestone Jan 24, 2022
@import-brain import-brain moved this to Todo in Faker Roadmap Jan 24, 2022
@harsohailB
Copy link
Contributor

@pkuczynski I would like to work on this feature. Feel free to assign me!

@harsohailB harsohailB mentioned this issue Apr 6, 2022
Merged
@Shinigami92 Shinigami92 linked a pull request Apr 7, 2022 that will close this issue
feat: special characters in emails #792
Merged
@Shinigami92 Shinigami92 moved this from Todo to In Progress in Faker Roadmap Apr 7, 2022
@Shinigami92 Shinigami92 added the s: accepted Accepted feature / Confirmed bug label Apr 7, 2022
Repository owner moved this from In Progress to Done in Faker Roadmap Apr 8, 2022
@ST-DDT ST-DDT removed this from Faker Roadmap Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harsohailB harsohailB

Labels
c: feature Request for new feature p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Milestone
v6.2 - New small features
Development

Successfully merging a pull request may close this issue.

feat: special characters in emails harsohailB/faker
5 participants
@pkuczynski @prisis @Shinigami92 @harsohailB @import-brain