-
-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vehicle): Make VIN number generation more accurate #2765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last six digits of VIN (vehicle identification number) is the number and the 13th digit (last five digits) can start with number 0 (zero).
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
matthewmayer
previously requested changes
Mar 23, 2024
xDivisionByZerox
added
p: 1-normal
Nothing urgent
m: vehicle
Something is referring to the vehicle module
labels
Mar 23, 2024
@faker-js/maintainers Is this a |
IMO |
xDivisionByZerox
changed the title
refactor(vehicle): Make VIN number generation more accurate
fix(vehicle): Make VIN number generation more accurate
Mar 23, 2024
xDivisionByZerox
previously approved these changes
Apr 25, 2024
xDivisionByZerox
approved these changes
Apr 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2765 +/- ##
==========================================
- Coverage 99.96% 99.95% -0.02%
==========================================
Files 2973 2973
Lines 212501 212501
Branches 950 942 -8
==========================================
- Hits 212429 212405 -24
- Misses 72 96 +24
|
ST-DDT
approved these changes
Apr 25, 2024
matthewmayer
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: bug
Something isn't working
m: vehicle
Something is referring to the vehicle module
p: 1-normal
Nothing urgent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last six digits of VIN (vehicle identification number) is the number and the 13th digit (last five digits) can start with number 0 (zero).