-
-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(locale)!: remove unused global locale faker instance #2789
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2789 +/- ##
==========================================
- Coverage 99.95% 99.95% -0.01%
==========================================
Files 2972 2971 -1
Lines 212564 212553 -11
Branches 952 594 -358
==========================================
- Hits 212470 212453 -17
- Misses 93 100 +7
+ Partials 1 0 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused here 🤔
Why is it okay here to remove it directly without any runtime deprecation warning?
Also, is this just a missed left-over and we forgot to remove it once we build the PR?
Because it was never meant to be in a release. This is an artifact from the introduction of the base locale, AFAICT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the responsibility on the other team-members, I approve
Removes the unused
global
faker instance that is only a copy of thebase
one.