-
-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(locale): normalize music data #2857
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xDivisionByZerox
added
p: 1-normal
Nothing urgent
c: refactor
PR that affects the runtime behavior, but doesn't add new features or fixes bugs
c: locale
Permutes locale definitions
m: music
Something is referring to the music module
labels
Apr 28, 2024
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2857 +/- ##
=======================================
Coverage ? 99.96%
=======================================
Files ? 2973
Lines ? 212501
Branches ? 597
=======================================
Hits ? 212422
Misses ? 79
Partials ? 0
|
matthewmayer
approved these changes
Apr 28, 2024
ST-DDT
approved these changes
Apr 28, 2024
Shinigami92
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: locale
Permutes locale definitions
c: refactor
PR that affects the runtime behavior, but doesn't add new features or fixes bugs
m: music
Something is referring to the music module
p: 1-normal
Nothing urgent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-on to #2265
Normalize the entries in the
music
module definitions in all locales.I choose this module as locale data are still limited. additionally, no data set exceedes the 1k entry limit, so all locale file changes are based on entry sorting.