-
-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate Planet names #2867
Comments
Thank you for your feature proposal. We marked it as "waiting for user interest" for now to gather some feedback from our community:
We would also like to hear about other community members' use cases for the feature to give us a better understanding of their potential implicit or explicit requirements. We will start the implementation based on:
We do this because:
|
Do you want exactly those well known planet names or any planet names? |
This was exactly my first thought. Even if we dont want scientific planets now, we might want to consider a method name that does not get in conflict if we want to generate names like |
Just the major planets |
Pluto is not a planet 😀 |
For comparison Faker-Ruby has a few space methods. Their "planet" method is "planet (in our solar System)" |
Currently, I think space is the best match, followed by location and then science. |
I understand your reasoning, but I'm not a big fan of introducing new modules at the current moment. We still have some places where we are not sure whether a function would be better located in module X or Y. Adding more modules makes this problem potentially worse until we have clear definitions about the "Module" term, or we introduce an easy way to reference aliases. That being said, I would not expect Another thing I want to point out is the method |
Nothing we have to decide now, lets wait on more input/upvotes. |
Clear and concise description of the problem
As a developer using faker i want to generate planet names.
Suggested solution
Implement
faker.science.planet()
with the following data in EnglishAlternative
faker.location.planet()
?Additional context
No response
The text was updated successfully, but these errors were encountered: