-
-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer a stable CDN over IPFS #2934
Comments
See also #2598. |
Which version of Faker are you using? The link seems to work fine for me, this might be a temporary problem. We plan to replace the legacy set in the future. Workaround: Use |
I am using
Sure. In the meantime, I propose faker could publish assets on a dedicated GitHub repo, and deliver them through a more stable GitHub CDN like |
As I already raised the idea of generating new person face images via Stable Diffusion and I do have now a good graphic card available, I will assign me to this issue |
I receive access denied. Is faker.image.avatar() deprecated? faker.image.avatarGitHub() sadly returns block art. |
Looks like cloudflare shut down that legacy image set.
No, its not. We probably have to remove the legacy images from it though.
Not exclusively, but sadly a lot of times. |
As I mentioned, we could use a stable CDN. Maybe we could ask @jimaek for jsDelivr's opinion on this. |
We don't own it, so we cannot bring it back as is. We could create a new image set, but that is covered by #465 and for that we will use a stable CDN/plattform. |
I created #3109 to deprecate the avatarLegacy method for removal. |
You could try the following instead: faker.image.urlLoremFlickr({ category: 'portrait', width: 400, height: 400 }) |
Pre-Checks
Describe the bug
I am using
faker.image.avatar()
method to get a random avatar URL.The method returns a random IPFS URL:
https://cloudflare-ipfs.com/ipfs/Qmd3W5DuhgHirLHGVixi6V76LhCkZUz6pnFt5AJBiyvHye/avatar/269.jpg
But to my surprise, the Cloudflare IPFS Gateway returns 504 error:
The IPFS gateway itself is working, but the asset can not be fetched by the gateway from the IPFS network.
Minimal reproduction code
No response
Additional Context
IMHO IPFS Gateway might not be that stable after all,
faker-js
could publish the random assets on a dedicated GitHub repo and use jsDelivr (or any other CDN) to deliver them.Environment Info
System: OS: Linux 6.8 Fedora Linux 40 (Workstation Edition) CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz Memory: 11.70 GB / 31.03 GB Container: Yes Shell: 5.9 - /usr/bin/zsh Binaries: Node: 18.19.0 - /run/user/1000/fnm_multishells/174660_1717401217872/bin/node npm: 10.2.3 - /run/user/1000/fnm_multishells/174660_1717401217872/bin/npm pnpm: 8.15.8 - /run/user/1000/fnm_multishells/174660_1717401217872/bin/pnpm bun: 1.1.10 - ~/.npm-global/bin/bun Browsers: Chrome: 125.0.6422.141
Which module system do you use?
Used Package Manager
pnpm
The text was updated successfully, but these errors were encountered: