fix: remove doubled extension in system.filePath

[pkuczynski]

system.filePath incorrectly creates results with two extensions. This PR is fixing this issue.

Steps to reproduce: faker.system.filePath()
Expected output: '/usr/local/src/money.dotx'
Actual output: '/usr/local/src/money.rmp.dotx'

[Shinigami92]

For me it currently looks like you

1. change the runtime behavior => so 6.1
2. declare it as p4 but change the comment that explains that it have a double file extension?!

Please do not miss-use the priority labels, this is not a p4, max p3, if this is even a bug at all 🤔

[ST-DDT]

if this is even a bug at all 🤔

IMO it's a bug or at least unexpected behavior, but nothing important.

[pkuczynski]

1. change the runtime behavior => so 6.1

Fixing a bug, so it is kind of "stability", but wasn't sure on your "terminology"

2. declare it as p4 but change the comment that explains that it have a double file extension?!

I am not sure what do you mean :/

Please do not miss-use the priority labels, this is not a p4, max p3, if this is even a bug at all 🤔

I was not sure if my labels are correct, hence I reached out on discord asking for help with this. I strongly believe it is a bug though.

[Shinigami92]

Tests are indicating that this was expected 🤔
Maybe we could just provide options and define how many extension will be added 🤔

[pkuczynski]

Tests are indicating that this was expected 🤔
Maybe we could just provide options and define how many extension will be added 🤔

These are the new tests. There were no old tests for this function AFAIK. And I can't really see why anyone would want to have dbl extensions in the filePath (by default)...?

[pkuczynski]

Maybe we could just provide options and define how many extension will be added 🤔

Added as a separate feat PR #395

[pkuczynski]

@Shinigami92 anything else to be done in this PR? I lost the track a little bit?

[codecov]

Codecov Report

Merging #300 (9bae9fc) into main (1bb0f25) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1924     1924           
  Lines      177021   177022    +1     
  Branches      904      904           
=======================================
+ Hits       175860   175861    +1     
  Misses       1105     1105           
  Partials       56       56           

Impacted Files	Coverage Δ
src/system.ts	96.46% <100.00%> (+0.01%)	⬆️