Note this should be cleaned up in other locales e.g. https://github.com/faker-js/faker/blob/next/src/locales/en/person/prefix.ts where generic is just the union of male and female.

Currently en has:

export default {
  generic: ['Dr.', 'Miss', 'Mr.', 'Mrs.', 'Ms.'],
  female: ['Mrs.', 'Ms.', 'Miss', 'Dr.'],
  male: ['Mr.', 'Dr.'],
};

which should be

export default {
  female: ['Mrs.', 'Ms.', 'Miss', 'Dr.'],
  male: ['Mr.', 'Dr.'],
};

although i'd argue it would be more sensibly written as

export default {
  generic: ['Dr.'],
  female: ['Mrs.', 'Ms.', 'Miss'],
  male: ['Mr.'],
};

However that won't work currently (as generic takes priority, so everyone would be Dr). Perhaps selectDefinition should return randomly from the generic plus female/male lists when sex is undefined?

Team Decision

• We decided to split the definitions by applicability.
• See this PR for details: refactor(person): refine usage of PersonEntryDefinitions #3259
  • refactor(person): refine usage of PersonEntryDefinitions #3259