Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated tests for fake patterns #3325

Open
ST-DDT opened this issue Dec 5, 2024 · 1 comment
Open

Add automated tests for fake patterns #3325

ST-DDT opened this issue Dec 5, 2024 · 1 comment
Labels
c: locale Permutes locale definitions c: test p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Dec 5, 2024

Clear and concise description of the problem

If we add or change fake patterns (or have to review them), we have to manually check for all possible combinations of patterns.

Suggested solution

Add an automated test that checks fake patterns for errors including errors in nested fake patterns.

Alternative

Keep testing by hand.

Additional context

We have to find a way to detect all fake patterns even if they aren't suffixed with pattern.

Found in: bfbd0b6

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: test s: accepted Accepted feature / Confirmed bug c: locale Permutes locale definitions labels Dec 5, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Dec 5, 2024
@matthewmayer
Copy link
Contributor

Sounds useful; though what errors specifically would you test for?

The typo i made could have been caught by checking for a balanced number of } and { characters, but not sure how common that would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions c: test p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

No branches or pull requests

2 participants