Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh examples button doesn't work for unreleased methods #3342

Open
matthewmayer opened this issue Dec 28, 2024 · 3 comments · May be fixed by #3343
Open

Refresh examples button doesn't work for unreleased methods #3342

matthewmayer opened this issue Dec 28, 2024 · 3 comments · May be fixed by #3343
Assignees
@ST-DDT
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Milestone
vAnytime

Comments

@matthewmayer
Copy link
Contributor

Noted at #3301 (comment)

For example the refresh button on next.fakerjs.dev for faker.location.language() doesn't work yet as the docs are for 9.4.0 but the JS pulled in is for 9.3.0

It would be nice if this could work to allow for easier testing of the examples for new methods.
@matthewmayer matthewmayer added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Dec 28, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Dec 28, 2024
@ST-DDT ST-DDT self-assigned this Dec 28, 2024
@ST-DDT ST-DDT linked a pull request Dec 28, 2024 that will close this issue
Open
@ST-DDT
Copy link
Member

ST-DDT commented Dec 28, 2024

Thanks for remembering/creating a tracking issue. ❤️
I hope I didn't "steal" this issue from you.

@ST-DDT
Copy link
Member

ST-DDT commented Jan 1, 2025

Would you consider this a release blocking issue?

@matthewmayer
Copy link
Contributor Author

Well no because once the release is released it's no longer an issue 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ST-DDT ST-DDT

Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging a pull request may close this issue.

docs: use embedded build for preview examples faker-js/faker
2 participants
@matthewmayer @ST-DDT