Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move random.word to word.any #339

Closed
pkuczynski opened this issue Jan 28, 2022 · 7 comments · Fixed by #714
Closed

Move random.word to word.any #339

pkuczynski opened this issue Jan 28, 2022 · 7 comments · Fixed by #714
Assignees
@pkuczynski @damienwebdev
Labels
c: feature Request for new feature good first issue Good for newcomers m: random Something is referring to the random module m: word Something is referring to the word module s: accepted Accepted feature / Confirmed bug
Milestone
v8.x

Comments

@pkuczynski
Copy link
Member

Clear and concise description of the problem

Most of the methods of random already found their new home, like random.number > datatype.number

Suggested solution

Move random.word to word.any and deprecate random.word.

Alternative

No response

Additional context

#276 (comment)
@pkuczynski pkuczynski added s: pending triage Pending Triage c: feature Request for new feature good first issue Good for newcomers labels Jan 28, 2022
@pkuczynski pkuczynski added this to the v6.2 - New small features milestone Jan 28, 2022
@github-actions github-actions bot removed the s: pending triage Pending Triage label Jan 28, 2022
@pkuczynski pkuczynski mentioned this issue Jan 28, 2022
Closed
@andrewgremlich
Copy link

I'll take this! Simple enough.

@andrewgremlich
Copy link

I see this PR though... should I wait until that is merged? #276

@pkuczynski
Copy link
Member Author

I see this PR though... should I wait until that is merged? #276

In principle no changes like this will be merged until 6.0 is released. So I would wait with this, yes.

@andrewgremlich
Copy link

Since 6.0 was released, I'll continue with this one!

@pkuczynski
Copy link
Member Author

Since 6.0 was released, I'll continue with this one!

Please don't. It has been already discussed and I am on it.

@andrewgremlich
Copy link

Sounds good!

@pkuczynski pkuczynski self-assigned this Mar 28, 2022
@ST-DDT ST-DDT moved this to In Progress in Faker Roadmap Mar 28, 2022
@pkuczynski pkuczynski mentioned this issue Mar 28, 2022
Merged
@xDivisionByZerox xDivisionByZerox added m: random Something is referring to the random module m: word Something is referring to the word module labels Jul 30, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Aug 28, 2022

I would like to get this implemented.

@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Aug 28, 2022
@ST-DDT ST-DDT mentioned this issue Aug 28, 2022
Merged
Repository owner moved this from In Progress to Done in Faker Roadmap Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkuczynski pkuczynski

@damienwebdev damienwebdev

Labels
c: feature Request for new feature good first issue Good for newcomers m: random Something is referring to the random module m: word Something is referring to the word module s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging a pull request may close this issue.

feat(word): add sample method pkuczynski/faker
6 participants
@pkuczynski @ST-DDT @Shinigami92 @damienwebdev @andrewgremlich @xDivisionByZerox