Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

English bicycle file is named incorrectly #379

Closed
ST-DDT opened this issue Jan 30, 2022 · 3 comments
Closed

English bicycle file is named incorrectly #379

ST-DDT opened this issue Jan 30, 2022 · 3 comments
Assignees
Labels
c: bug Something isn't working

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Jan 30, 2022

Describe the bug

src/locales/en/vehicle/bicycle.ts should be named src/locales/en/vehicle/bicycle_type.ts

(Other languages might be affected as well)

Reproduction

faker.vehicle.bicycle() => c which is one of the defaults if the array is missing.

Additional Info

Found in #363

@ST-DDT ST-DDT added the c: bug Something isn't working label Jan 30, 2022
@Shinigami92
Copy link
Member

So will this

also be renamed?

Why is this needed? I currently don't quite understand by reading the description of this issue.

@ST-DDT
Copy link
Member Author

ST-DDT commented Jan 31, 2022

The locale api expects the key to be named bicycle_type, but currently it is named bicycle.
(Thus it wont be used)
Since all keys are named like the files (to help with automation), the file has to be renamed as well.

This should potentially be fixed after #363 to avoid merge conflicts.
The index.ts file can be updated automatically when #252 is merged.

@ST-DDT
Copy link
Member Author

ST-DDT commented Feb 20, 2022

Fixed in #477

@ST-DDT ST-DDT closed this as completed Feb 20, 2022
Repository owner moved this from Todo to Done in Faker Roadmap Feb 20, 2022
@ST-DDT ST-DDT self-assigned this Feb 20, 2022
@ST-DDT ST-DDT removed this from Faker Roadmap Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants