fix: optional args on faker.finance.iban() #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`faker.finance.iban()` is a valid use of Faker. However in TypeScript you get a type error because the optional `formatted` and `countryCode` args are not marked as optional like in other functions. Tests are written against the cjs bundle without types so did not catch the error.
Codecov Report
@@ Coverage Diff @@
## main #431 +/- ##
=======================================
Coverage 94.24% 94.24%
=======================================
Files 1920 1920
Lines 173955 173955
Branches 108 108
=======================================
Hits 163942 163942
Misses 9905 9905
Partials 108 108
|
|
FFR: In definitely typed it was supported and the code (both impl and test) looks like it is optional as well. So we should restore the original behavior. If you are familiar with ts, could you please also remove the ts-expect-error from the Thanks for your contribution. |
ST-DDT
approved these changes
Feb 5, 2022
|
I have to check why the code cov is reported as zero for this patch. The tests should be covering this. |
Maybe because that's a diff, I only made a one character type change, and none of the tests cover types. |
Shinigami92
approved these changes
Feb 5, 2022
demipel8
pushed a commit
to demipel8/faker
that referenced
this pull request
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
faker.finance.iban()is a valid use of Faker. However in TypeScript you get a type error because the optionalformattedandcountryCodeargs are not marked as optional like in other functions.Tests are written against the cjs bundle without types so did not catch the error.