Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: various fixes #523

Merged
merged 2 commits into from
Feb 20, 2022
Merged

docs: various fixes #523

merged 2 commits into from
Feb 20, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Feb 20, 2022

Ref: #203 , #514

I found various issues in the docs that I would like to address.

Mostly this is some minor stuff like a missing dot.

@ST-DDT ST-DDT added the c: docs Improvements or additions to documentation label Feb 20, 2022
@ST-DDT ST-DDT self-assigned this Feb 20, 2022
@ST-DDT ST-DDT requested a review from a team as a code owner February 20, 2022 01:16
@codecov
Copy link

codecov bot commented Feb 20, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@f7899fd). Click here to learn what that means.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #523   +/-   ##
=======================================
  Coverage        ?   99.34%           
=======================================
  Files           ?     1919           
  Lines           ?   176315           
  Branches        ?      904           
=======================================
  Hits            ?   175158           
  Misses          ?     1101           
  Partials        ?       56           
Impacted Files Coverage Δ
src/datatype.ts 99.66% <100.00%> (ø)
src/date.ts 100.00% <100.00%> (ø)
src/finance.ts 99.32% <100.00%> (ø)
src/helpers.ts 99.55% <100.00%> (ø)
src/image.ts 99.41% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)
src/internet.ts 100.00% <100.00%> (ø)
src/lorem.ts 100.00% <100.00%> (ø)
src/mersenne.ts 100.00% <100.00%> (ø)
src/name.ts 95.82% <100.00%> (ø)
... and 4 more

import-brain
import-brain previously approved these changes Feb 20, 2022
Shinigami92
Shinigami92 previously approved these changes Feb 20, 2022
@ST-DDT ST-DDT requested a review from a team February 20, 2022 15:36
src/finance.ts Show resolved Hide resolved
prisis
prisis previously approved these changes Feb 20, 2022
@Shinigami92 Shinigami92 dismissed stale reviews from prisis, import-brain, and themself via 72fda24 February 20, 2022 17:46
@Shinigami92 Shinigami92 merged commit b22cf3b into main Feb 20, 2022
@Shinigami92 Shinigami92 deleted the docs/various-fixes branch February 20, 2022 17:51
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants