fix: correcting the readme file #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MostlyWhat
changed the title
|
Deno is a thing too: https://deno.land/ |
Codecov Report
@@ Coverage Diff @@
## main #529 +/- ##
=======================================
Coverage 99.34% 99.34%
=======================================
Files 1919 1919
Lines 176364 176364
Branches 902 905 +3
=======================================
+ Hits 175208 175210 +2
+ Misses 1100 1098 -2
Partials 56 56
|
ST-DDT
requested changes
Feb 21, 2022
ST-DDT
added
c: docs
Shinigami92
requested changes
Feb 23, 2022
README.md
Outdated
| @@ -59,7 +59,7 @@ const randomEmail = faker.internet.email(); // Kassandra.Haley@erich.biz | |||
| const randomCard = faker.helpers.createCard(); // random contact card containing many properties | |||
| ``` | |||
|
|
|||
| ### Deno | |||
| ### CDN Demo | |||
There was a problem hiding this comment.
I assume something was mixed up while merging main 🤔
This line should address Deno
There was a problem hiding this comment.
I thought I merged the change above
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
|
I think I modified it. |
Shinigami92
approved these changes
Feb 24, 2022
ST-DDT
approved these changes
Feb 24, 2022
demipel8
pushed a commit
to demipel8/faker
that referenced
this pull request
Mar 11, 2022
ST-DDT
modified the milestones:
v6 - Non-Breaking Changes,
v6.0 - Ensure Project Foundation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readme file used to say Deno but I feel like using "CDN Demo" seems more fitting.