Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alphaNumeric all chars banned #550

Merged
merged 4 commits into from
Mar 21, 2022
Merged

fix: alphaNumeric all chars banned #550

merged 4 commits into from
Mar 21, 2022

Conversation

xDivisionByZerox
Copy link
Member

Created in relation to #518.

  • remove additional if check against options argument
  • throw if no characters to pick from are available
  • activate test case

@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner February 23, 2022 19:46
@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #550 (e6515c9) into main (5a15c40) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head e6515c9 differs from pull request most recent head b837232. Consider uploading reports for the commit b837232 to get more accurate results

@@           Coverage Diff           @@
##             main     #550   +/-   ##
=======================================
  Coverage   99.33%   99.33%           
=======================================
  Files        1920     1920           
  Lines      176482   176489    +7     
  Branches      905      908    +3     
=======================================
+ Hits       175302   175309    +7     
  Misses       1124     1124           
  Partials       56       56           
Impacted Files Coverage Δ
src/random.ts 99.22% <100.00%> (+<0.01%) ⬆️
src/helpers.ts 99.10% <0.00%> (-0.03%) ⬇️
src/iban.ts 100.00% <0.00%> (ø)

ST-DDT
ST-DDT previously approved these changes Feb 23, 2022
@ST-DDT ST-DDT requested a review from a team February 23, 2022 23:10
@import-brain import-brain added the c: bug Something isn't working label Feb 24, 2022
@ST-DDT ST-DDT linked an issue Feb 26, 2022 that may be closed by this pull request
src/random.ts Outdated Show resolved Hide resolved
src/random.ts Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent and removed p: 2-high Fix main branch labels Mar 15, 2022
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Mar 21, 2022
@Shinigami92 Shinigami92 enabled auto-merge (squash) March 21, 2022 13:07
@Shinigami92 Shinigami92 merged commit c51fb15 into faker-js:main Mar 21, 2022
@xDivisionByZerox xDivisionByZerox deleted the fix/alpha-numeric-all-chars-banned branch April 15, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected behavior of alphaNumeric with all chars banned
4 participants