-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: alphaNumeric all chars banned #550
Merged
Shinigami92
merged 4 commits into
faker-js:main
from
xDivisionByZerox:fix/alpha-numeric-all-chars-banned
Mar 21, 2022
Merged
fix: alphaNumeric all chars banned #550
Shinigami92
merged 4 commits into
faker-js:main
from
xDivisionByZerox:fix/alpha-numeric-all-chars-banned
Mar 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #550 +/- ##
=======================================
Coverage 99.33% 99.33%
=======================================
Files 1920 1920
Lines 176482 176489 +7
Branches 905 908 +3
=======================================
+ Hits 175302 175309 +7
Misses 1124 1124
Partials 56 56
|
ST-DDT
previously approved these changes
Feb 23, 2022
Shinigami92
reviewed
Mar 10, 2022
Shinigami92
added
p: 1-normal
Nothing urgent
and removed
p: 2-high
Fix main branch
labels
Mar 15, 2022
ST-DDT
approved these changes
Mar 21, 2022
Shinigami92
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: bug
Something isn't working
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created in relation to #518.
if
check againstoptions
argument