Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: configure eqeqeq lint rule #595

Merged
merged 3 commits into from
Mar 7, 2022
Merged

chore: configure eqeqeq lint rule #595

merged 3 commits into from
Mar 7, 2022

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Mar 4, 2022 •
edited
Loading

Related to #589 (comment)

@Shinigami92 Shinigami92 added the c: chore PR that doesn't affect the runtime behavior label Mar 4, 2022
@Shinigami92 Shinigami92 self-assigned this Mar 4, 2022
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 4, 2022 11:18
ST-DDT
ST-DDT reviewed Mar 4, 2022
View reviewed changes
test/address.spec.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 4, 2022 •
edited
Loading

Codecov Report

Merging #595 (b390989) into main (c99160f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head b390989 differs from pull request most recent head 822f312. Consider uploading reports for the commit 822f312 to get more accurate results

@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
- Coverage   99.34%   99.33%   -0.02%     
==========================================
  Files        1920     1920              
  Lines      176444   176424      -20     
  Branches      904      900       -4     
==========================================
- Hits       175287   175247      -40     
- Misses       1101     1121      +20     
  Partials       56       56
Impacted Files Coverage Δ
src/datatype.ts 99.66% <100.00%> (ø)
src/date.ts 100.00% <100.00%> (ø)
src/finance.ts 99.32% <100.00%> (ø)
src/helpers.ts 99.25% <100.00%> (-0.30%) ⬇️
src/internet.ts 100.00% <100.00%> (ø)
src/lorem.ts 100.00% <100.00%> (ø)
src/mersenne.ts 100.00% <100.00%> (ø)
src/vendor/mersenne.ts 93.85% <100.00%> (-2.05%) ⬇️
src/word.ts 100.00% <100.00%> (ø)
... and 11 more

@ST-DDT ST-DDT requested a review from a team March 4, 2022 11:25
@Shinigami92 Shinigami92 mentioned this pull request Mar 4, 2022
Merged
@Shinigami92 Shinigami92 merged commit 5cd3dae into main Mar 7, 2022
@Shinigami92 Shinigami92 deleted the lint-configure-eqeqeq branch March 7, 2022 20:01
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
@Shinigami92 @demipel8
chore: configure eqeqeq lint rule (faker-js#595)
abc3deb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prisis prisis prisis approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: chore PR that doesn't affect the runtime behavior
Projects
None yet
Milestone
v6.0 - Ensure Project Foundation
Development

Successfully merging this pull request may close these issues.
3 participants
@Shinigami92 @ST-DDT @prisis