Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only return word with desirable alpha characters #654

Merged
merged 7 commits into from
Mar 24, 2022
Merged

fix: only return word with desirable alpha characters #654

merged 7 commits into from
Mar 24, 2022

Conversation

Shinigami92
Copy link
Member

fix #113

@Shinigami92 Shinigami92 added c: bug Something isn't working p: 1-normal Nothing urgent labels Mar 22, 2022
@Shinigami92 Shinigami92 added this to the v6.1 - First bugfixes milestone Mar 22, 2022
@Shinigami92 Shinigami92 self-assigned this Mar 22, 2022
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 22, 2022 09:12
@Shinigami92 Shinigami92 requested a review from griest024 March 22, 2022 09:13
@codecov
Copy link

codecov bot commented Mar 22, 2022 •
edited
Loading

Codecov Report

Merging #654 (a25a570) into main (0924e85) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #654   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1923     1923           
  Lines      176837   176863   +26     
  Branches      900      902    +2     
=======================================
+ Hits       175678   175704   +26     
  Misses       1103     1103           
  Partials       56       56
Impacted Files Coverage Δ
src/random.ts 99.44% <100.00%> (+0.02%) ⬆️

ST-DDT
ST-DDT reviewed Mar 22, 2022
View reviewed changes
src/random.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT requested a review from a team March 22, 2022 10:06
@ST-DDT ST-DDT added the s: needs decision Needs team/maintainer decision label Mar 22, 2022
@Shinigami92 Shinigami92 marked this pull request as draft March 22, 2022 14:07
@Shinigami92 Shinigami92 marked this pull request as ready for review March 22, 2022 14:45
@Shinigami92 Shinigami92 requested a review from ST-DDT March 22, 2022 14:46
ST-DDT
ST-DDT reviewed Mar 22, 2022
View reviewed changes
src/random.ts Show resolved Hide resolved
@Shinigami92 Shinigami92 requested a review from ST-DDT March 22, 2022 15:23
ST-DDT
ST-DDT reviewed Mar 22, 2022
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Shinigami92 Shinigami92 requested a review from a team March 22, 2022 18:07
@Shinigami92 Shinigami92 requested a review from ST-DDT March 24, 2022 08:10
@Shinigami92 Shinigami92 requested a review from a team March 24, 2022 08:28
@Shinigami92 Shinigami92 removed the s: needs decision Needs team/maintainer decision label Mar 24, 2022
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Mar 24, 2022
@Shinigami92 Shinigami92 enabled auto-merge (squash) March 24, 2022 11:36
@Shinigami92 Shinigami92 merged commit b7b2e4f into main Mar 24, 2022
@Shinigami92 Shinigami92 deleted the 113-fix-random-word branch March 25, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prisis prisis prisis approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@griest024 griest024 Awaiting requested review from griest024

Assignees

@Shinigami92 Shinigami92

Labels
c: bug Something isn't working p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Milestone
v6.1 - First bugfixes
Development

Successfully merging this pull request may close these issues.

random.word() can return undesirable non-alpha characters
3 participants
@Shinigami92 @ST-DDT @prisis