Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more arabic names dataset #655

Merged
merged 7 commits into from
Apr 5, 2022
Merged

Conversation

wael-fadlallah
Copy link
Contributor

No description provided.

@wael-fadlallah wael-fadlallah requested a review from a team as a code owner March 22, 2022 10:52
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #655 (07203e2) into main (b34ef46) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 07203e2 differs from pull request most recent head e6c7e01. Consider uploading reports for the commit e6c7e01 to get more accurate results

@@            Coverage Diff             @@
##             main     #655      +/-   ##
==========================================
- Coverage   99.34%   99.34%   -0.01%     
==========================================
  Files        1918     1927       +9     
  Lines      176475   177054     +579     
  Branches      912      904       -8     
==========================================
+ Hits       175318   175893     +575     
- Misses       1101     1105       +4     
  Partials       56       56              
Impacted Files Coverage Δ
src/locales/ar/name/female_first_name.ts 100.00% <100.00%> (ø)
src/locales/ar/name/index.ts 100.00% <100.00%> (ø)
src/locales/ar/name/male_first_name.ts 100.00% <100.00%> (ø)
src/locales/ar/name/suffix.ts 100.00% <100.00%> (ø)
src/helpers.ts 99.14% <0.00%> (-0.14%) ⬇️
src/random.ts 99.46% <0.00%> (-0.01%) ⬇️
src/finance.ts 99.30% <0.00%> (-0.01%) ⬇️
src/fake.ts 100.00% <0.00%> (ø)
src/faker.ts 100.00% <0.00%> (ø)
src/commerce.ts 100.00% <0.00%> (ø)
... and 26 more

@import-brain import-brain added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Mar 22, 2022
@Shinigami92
Copy link
Member

@wael-fadlallah
We have some logic that benefits if there is a male_first_name beside the female_first_name file.
Would you like to add a src/locales/ar/name/male_first_name.ts with at least 5 male names? That would be nice.

@Shinigami92 Shinigami92 added the s: accepted Accepted feature / Confirmed bug label Mar 22, 2022
@Shinigami92 Shinigami92 added this to the v6.2 - New small features milestone Mar 22, 2022
@Shinigami92 Shinigami92 self-requested a review March 22, 2022 18:56
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run pnpm run generate:locales.

@wael-fadlallah wael-fadlallah requested a review from ST-DDT March 26, 2022 09:56
@ST-DDT ST-DDT requested review from a team March 28, 2022 08:32
@Shinigami92 Shinigami92 enabled auto-merge (squash) April 5, 2022 15:19
@Shinigami92 Shinigami92 merged commit b3a9abc into faker-js:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants