Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: configure eol character for git.commitEntry #681

Merged
merged 8 commits into from
Apr 23, 2022
Merged

feat: configure eol character for git.commitEntry #681

merged 8 commits into from
Apr 23, 2022

Conversation

xDivisionByZerox
Copy link
Member

Fixes #679

@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner March 26, 2022 13:16
@codecov
Copy link

codecov bot commented Mar 26, 2022 •
edited
Loading

Codecov Report

Merging #681 (a2ce169) into main (0594103) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #681   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files        1958     1958           
  Lines      210788   210804   +16     
  Branches      903      905    +2     
=======================================
+ Hits       209572   209590   +18     
+ Misses       1159     1157    -2     
  Partials       57       57
Impacted Files Coverage Δ
src/git.ts 100.00% <100.00%> (+1.69%) ⬆️

@import-brain import-brain added c: feature Request for new feature p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Mar 26, 2022
import-brain
import-brain previously approved these changes Mar 26, 2022
View reviewed changes
ST-DDT
ST-DDT previously approved these changes Mar 31, 2022
View reviewed changes
import-brain
import-brain previously approved these changes Apr 1, 2022
View reviewed changes
@ST-DDT ST-DDT requested a review from a team April 2, 2022 14:54
Shinigami92
Shinigami92 requested changes Apr 5, 2022
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a test for the parameter

@Shinigami92 Shinigami92 added the needs test More tests are needed label Apr 5, 2022
@xDivisionByZerox xDivisionByZerox dismissed stale reviews from import-brain and ST-DDT via 3326634 April 23, 2022 08:58
ST-DDT
ST-DDT requested changes Apr 23, 2022
View reviewed changes
src/git.ts Outdated Show resolved Hide resolved
ST-DDT
ST-DDT requested changes Apr 23, 2022
View reviewed changes
test/git.spec.ts Outdated Show resolved Hide resolved
test/git.spec.ts Outdated Show resolved Hide resolved
test/git.spec.ts Show resolved Hide resolved
@ST-DDT ST-DDT requested a review from a team April 23, 2022 10:34
@ST-DDT ST-DDT requested a review from a team April 23, 2022 10:34
@ST-DDT ST-DDT removed the needs test More tests are needed label Apr 23, 2022
@Shinigami92 Shinigami92 changed the title feat(git.commitEntry): configure eol charcter feat: configure eol character for git.commitEntry Apr 23, 2022
@Shinigami92 Shinigami92 enabled auto-merge (squash) April 23, 2022 10:50
@Shinigami92 Shinigami92 merged commit f797b63 into faker-js:main Apr 23, 2022
@xDivisionByZerox xDivisionByZerox deleted the commit-entry-eol-configuration branch April 23, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@import-brain import-brain import-brain left review comments

Assignees

@xDivisionByZerox xDivisionByZerox

Labels
c: feature Request for new feature p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Milestone
v6.3 - Next Minor
Development

Successfully merging this pull request may close these issues.

git.commitEntry make end of line style configurable
4 participants
@xDivisionByZerox @ST-DDT @Shinigami92 @import-brain