fix: deterministic results for address.nearbyGPSCoordinate

[xDivisionByZerox]

closes #736

[codecov]

Codecov Report

Merging #737 (d7a9317) into main (c3be3b1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d7a9317 differs from pull request most recent head cbf2384. Consider uploading reports for the commit cbf2384 to get more accurate results

@@           Coverage Diff           @@
##             main     #737   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1925     1925           
  Lines      177024   177030    +6     
  Branches      909      909           
=======================================
+ Hits       175871   175877    +6     
  Misses       1097     1097           
  Partials       56       56           

Impacted Files	Coverage Δ
src/address.ts	99.11% <100.00%> (+<0.01%)	⬆️

[Shinigami92]

@xDivisionByZerox Tests need update (?)

[xDivisionByZerox]

I'm testing local again to see if I forgot something, but I normally always run tests locally before pushing :/

[xDivisionByZerox]

The max: 360 property in datatype.number implemented a rounding change on the 4th decimal place of 1 expect value :)

[xDivisionByZerox]

The max: 360 property in datatype.number implemented a rounding change on the 4th decimal place of 1 expect value :)

Well, that's funny;
If I set up a test by myself I get [ '-0.0394', '0.0396' ] as result.

import { faker } from './src';

faker.seed(42);
console.log(faker.address.nearbyGPSCoordinate([0, 0]));

But if I run the test suite it gets [ '-0.0393', '0.0396' ]

[Shinigami92]

Should we use 1e-5 ?

[ST-DDT]

I think 0.01 is enough.

EDIT: Let me do some quick math.

[xDivisionByZerox]

I think 0.01 is enough.

I'll just do that. With 4 decimal points, it just works sometimes and sometimes it doesn't.

[xDivisionByZerox]

Let's see if this works one last time before I update the precision.

[xDivisionByZerox]

🎉🎉🎉