feat: use street address templates from locales #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
c: feature
Codecov Report
@@ Coverage Diff @@
## main #754 +/- ##
=======================================
Coverage 99.34% 99.34%
=======================================
Files 1921 1921
Lines 176540 176628 +88
Branches 908 906 -2
=======================================
+ Hits 175387 175475 +88
Misses 1097 1097
Partials 56 56
|
|
Depends on #756 |
ST-DDT
added
s: on hold
|
#756 was merged |
|
I converted the street_address templates using the following script: function updateLocaleFileHook(
filePath: string,
locale: string,
localePath: string[]
): void {
if (localePath[0] === 'address' && localePath[1] === 'street_address') {
console.log(filePath + ' <-> ' + locale + ' @ ' + localePath.join(' -> '));
let content: string[] = require(filePath).default.map((entry) =>
entry
.replace('#{street_name}', '{{address.streetName}}')
.replace('#{address.street_name}', '{{address.streetName}}')
.replace('#{building_number}', '{{address.buildingNumber}}')
.replace('#{address.building_number}', '{{address.buildingNumber}}')
.replace('#{secondary_address}', '{{address.secondaryAddress}}')
);
content = [
content[0].replace(' {{address.secondaryAddress}}', '').replace(/,$/, ''),
content[1] ??
content[0].replace(' {{address.secondaryAddress}}', '') +
' {{address.secondaryAddress}}',
];
let fileContent =
'export default ' + JSON.stringify(content) + ' as [string, string]';
fileContent = format(fileContent, prettierTsOptions);
console.log(fileContent);
writeFileSync(filePath, fileContent);
}
}During the implementation I noticed, that some locale files contained two patterns, one with the normal pattern and one with the full pattern. I'm not sure whether |
ST-DDT
commented
Apr 2, 2022
Here are some examples for the generated addresses: (click to expand)
|
Polish one ( |
pkuczynski
reviewed
Apr 3, 2022
I could change/fix the format here, but it might be best if you create a separate PR for that (format/street address, street name, building number and secondary address) |
|
Like this? |
Shinigami92
approved these changes
Apr 5, 2022
pkuczynski
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds #88
faker.address.buildingNumber()faker.address.streetAddress()to use the templates from the localesfake()format