Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use \n as default separator for lorem.paragraphs() #783

Merged
merged 4 commits into from
Apr 5, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Apr 5, 2022

As an alternative, we could use the current system EOL (or just \n).

Ref: #541

@ST-DDT ST-DDT added c: bug Something isn't working p: 1-normal Nothing urgent labels Apr 5, 2022
@ST-DDT ST-DDT added this to the v6 - Non-Breaking Changes milestone Apr 5, 2022
@ST-DDT ST-DDT requested review from a team April 5, 2022 21:02
@ST-DDT ST-DDT self-assigned this Apr 5, 2022
@ST-DDT ST-DDT mentioned this pull request Apr 5, 2022
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #783 (93a64d9) into main (28f4946) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 93a64d9 differs from pull request most recent head d40646b. Consider uploading reports for the commit d40646b to get more accurate results

@@           Coverage Diff           @@
##             main     #783   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1921     1921           
  Lines      176541   176540    -1     
  Branches      908      908           
=======================================
- Hits       175388   175387    -1     
  Misses       1097     1097           
  Partials       56       56           
Impacted Files Coverage Δ
src/lorem.ts 100.00% <100.00%> (ø)

@ST-DDT ST-DDT requested a review from a team April 5, 2022 21:22
@Shinigami92 Shinigami92 changed the title fix: use proper separator for lorem.paragraphs() fix: use \n as default separator for lorem.paragraphs() Apr 5, 2022
@Shinigami92 Shinigami92 added the s: accepted Accepted feature / Confirmed bug label Apr 5, 2022
@Shinigami92 Shinigami92 enabled auto-merge (squash) April 5, 2022 21:23
@Shinigami92 Shinigami92 merged commit 6a2d8fc into main Apr 5, 2022
@ST-DDT ST-DDT deleted the fix/lorem/paragraphs-strange-separators branch April 5, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants