refactor!: get rid of export =

[Shinigami92]

This PR is an requirement for #848

[Shinigami92]

We need to decide if we want to introduce a breaking change and users need to use require('@faker-js/faker/locale/en').default or if we want back somehow the current behavior without .default.
It looks like we are trapped in a legacy design issue with that.

[codecov]

Codecov Report

Merging #849 (5e73fc3) into main (a2da7c4) will increase coverage by 0.51%.
The diff coverage is 100.00%.

❗ Current head 5e73fc3 differs from pull request most recent head 2751fcc. Consider uploading reports for the commit 2751fcc to get more accurate results

@@            Coverage Diff             @@
##             main     #849      +/-   ##
==========================================
+ Coverage   99.13%   99.64%   +0.51%     
==========================================
  Files        1958     1958              
  Lines      210793   210679     -114     
  Branches      906      907       +1     
==========================================
+ Hits       208964   209931     +967     
+ Misses       1753      729    -1024     
+ Partials       76       19      -57     

Impacted Files	Coverage Δ
src/locale/af_ZA.ts	100.00% <100.00%> (+100.00%)	⬆️
src/locale/ar.ts	100.00% <100.00%> (+100.00%)	⬆️
src/locale/az.ts	100.00% <100.00%> (+100.00%)	⬆️
src/locale/cz.ts	100.00% <100.00%> (+100.00%)	⬆️
src/locale/de.ts	100.00% <100.00%> (+100.00%)	⬆️
src/locale/de_AT.ts	100.00% <100.00%> (+100.00%)	⬆️
src/locale/de_CH.ts	100.00% <100.00%> (+100.00%)	⬆️
src/locale/el.ts	100.00% <100.00%> (+100.00%)	⬆️
src/locale/en.ts	100.00% <100.00%> (+100.00%)	⬆️
src/locale/en_AU.ts	100.00% <100.00%> (+100.00%)	⬆️
... and 104 more

[Shinigami92]

An alternative could be to switch totally to export { faker };
and then users need to use

// js
const fakerEn = require('@faker-js/faker/locale/en').faker
const { faker: fakerEn } = require('@faker-js/faker/locale/en')

// ts
const { faker } from '@faker-js/faker/locale/en'
const { faker as fakerEn } from '@faker-js/faker/locale/en'

This is more verbose but also has the benefit of just swapping out from '@faker-js/faker' => '@faker-js/faker/locale/en' 🤔

[ST-DDT]

I like that alternative proposal.
I assume most of the time you only need a specific language anyway.

[Shinigami92]

I like that alternative proposal. I assume most of the time you only need a specific language anyway.

@prisis I would like to hear your vote for that, if you also accept, I will refactor it to that

[prisis]

Im voting for the alternative proposal too, @Shinigami92

[ST-DDT]

Doesn't this contain the changes from?
#850

[Shinigami92]

Doesn't this contain the changes from? #850

Not anymore 😉