Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation messages are logged while accessing faker #856

Closed
Shinigami92 opened this issue Apr 20, 2022 · 0 comments · Fixed by #857
Closed

Deprecation messages are logged while accessing faker #856

Shinigami92 opened this issue Apr 20, 2022 · 0 comments · Fixed by #857
Assignees
@Shinigami92
Labels
c: bug Something isn't working p: 3-urgent Fix and release ASAP s: accepted Accepted feature / Confirmed bug
Milestone
v6.2 - New small ...

Comments

@Shinigami92
Copy link
Member

Shinigami92 commented Apr 20, 2022 •
edited
Loading

Describe the bug

When just using the faker instance, then deprecation warnings are logged for getters as they are executed in module constructors cause of the this-bindings

faker/src/unique.ts

Line 86 in b10f00c

if (name === 'constructor' || typeof this[name] !== 'function') {

This is blocking the release of v6.2.0

Reproduction

Additional Info

Found by @ST-DDT
@Shinigami92 Shinigami92 added c: bug Something isn't working p: 3-urgent Fix and release ASAP s: accepted Accepted feature / Confirmed bug labels Apr 20, 2022
@Shinigami92 Shinigami92 added this to the v6.2 - New small features milestone Apr 20, 2022
@Shinigami92 Shinigami92 moved this to Todo in Faker Roadmap Apr 20, 2022
@Shinigami92 Shinigami92 linked a pull request Apr 20, 2022 that will close this issue
fix: dont log deprecations on startup #857
Merged
@Shinigami92 Shinigami92 self-assigned this Apr 20, 2022
@Shinigami92 Shinigami92 moved this from Todo to In Progress in Faker Roadmap Apr 20, 2022
@Shinigami92 Shinigami92 moved this from In Progress to Awaiting Review in Faker Roadmap Apr 20, 2022
Repository owner moved this from Awaiting Review to Done in Faker Roadmap Apr 21, 2022
@ST-DDT ST-DDT removed this from Faker Roadmap Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shinigami92 Shinigami92

Labels
c: bug Something isn't working p: 3-urgent Fix and release ASAP s: accepted Accepted feature / Confirmed bug
Projects
None yet
Milestone
v6.2 - New small features
Development

Successfully merging a pull request may close this issue.

fix: dont log deprecations on startup faker-js/faker
1 participant
@Shinigami92