-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typo in error message #925
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👍 |
Codecov Report
@@ Coverage Diff @@
## main #925 +/- ##
=======================================
Coverage 99.66% 99.66%
=======================================
Files 1957 1957
Lines 209797 209797
Branches 886 886
=======================================
Hits 209087 209087
Misses 690 690
Partials 20 20
|
Shinigami92
reviewed
May 5, 2022
Shinigami92
changed the title
fix: correct a typo in an error message (then > than)
fix: typo in error message
May 5, 2022
Shinigami92
added
c: chore
PR that doesn't affect the runtime behavior
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
labels
May 5, 2022
Shinigami92
approved these changes
May 5, 2022
ST-DDT
approved these changes
May 5, 2022
xDivisionByZerox
approved these changes
May 5, 2022
xDivisionByZerox
added
the
m: datatype
Something is referring to the datatype module
label
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: chore
PR that doesn't affect the runtime behavior
m: datatype
Something is referring to the datatype module
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a typo in the preposition in an error message.
An example of what the error message reads currently:
This erroneously uses the word then instead of the preposition than used for comparisons. The message should have read instead,
Max 0 should be larger than min 2.
Might also want to consider changing larger than to greater than.