Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in error message #925

Merged
merged 3 commits into from
May 5, 2022
Merged

fix: typo in error message #925

merged 3 commits into from
May 5, 2022

Conversation

azangru
Copy link
Contributor

@azangru azangru commented May 4, 2022

This PR fixes a typo in the preposition in an error message.

An example of what the error message reads currently:

Max 0 should be larger then min 2.

This erroneously uses the word then instead of the preposition than used for comparisons. The message should have read instead, Max 0 should be larger than min 2.

Might also want to consider changing larger than to greater than.

@azangru azangru requested a review from a team as a code owner May 4, 2022 22:52
@ST-DDT
Copy link
Member

ST-DDT commented May 4, 2022

Might also want to consider changing larger than to greater than.

👍

@ST-DDT ST-DDT added this to the v7 - Current Major milestone May 4, 2022
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #925 (ceb5d75) into main (b4cadfa) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #925   +/-   ##
=======================================
  Coverage   99.66%   99.66%           
=======================================
  Files        1957     1957           
  Lines      209797   209797           
  Branches      886      886           
=======================================
  Hits       209087   209087           
  Misses        690      690           
  Partials       20       20           
Impacted Files Coverage Δ
src/modules/datatype/index.ts 100.00% <100.00%> (ø)

src/modules/datatype/index.ts Outdated Show resolved Hide resolved
test/datatype.spec.ts Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 changed the title fix: correct a typo in an error message (then > than) fix: typo in error message May 5, 2022
@Shinigami92 Shinigami92 added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels May 5, 2022
@Shinigami92 Shinigami92 requested review from a team May 5, 2022 09:00
@ST-DDT ST-DDT merged commit 3ea64ce into faker-js:main May 5, 2022
@xDivisionByZerox xDivisionByZerox added the m: datatype Something is referring to the datatype module label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior m: datatype Something is referring to the datatype module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants