-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use localized fake pattern in street #966
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
c: feature
Request for new feature
p: 1-normal
Nothing urgent
c: locale
Permutes locale definitions
labels
May 17, 2022
ST-DDT
commented
May 17, 2022
Codecov Report
@@ Coverage Diff @@
## main #966 +/- ##
=======================================
Coverage ? 99.65%
=======================================
Files ? 1988
Lines ? 210187
Branches ? 888
=======================================
Hits ? 209468
Misses ? 700
Partials ? 19
|
Shinigami92
previously approved these changes
May 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trust-bonus-approval 😜
import-brain
previously approved these changes
May 17, 2022
Shinigami92
approved these changes
May 19, 2022
import-brain
approved these changes
May 20, 2022
xDivisionByZerox
added
the
m: location
Something is referring to the location module
label
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: feature
Request for new feature
c: locale
Permutes locale definitions
m: location
Something is referring to the location module
p: 1-normal
Nothing urgent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
address.street
method to use theaddress.street
locale data with fake to generate street names.For that I checked, that all street files are named correctly (street -> patterns; street _name -> actual street names).
I did not check whether the specified patterns make sense or the street names are real.
I generated the missing street files with the original pattern from the method to ensure it does not break between versions.
I did not add
'{{address.street_name}}'
to the street patterns if both the street and street_name files exist .I did not remove it from the patterns if the street_name file is missing in that locale.
Everything in the first commit was generated by using this code:
generateLocales.ts
And executed it using this helper: