Support search for ruby less than 2.4.0
#12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Symbol#match?` method is missing for older rubies
akabiru
reviewed
Oct 4, 2018
lib/fakerbot/version.rb
Outdated
| module FakerBot | ||
| VERSION = '0.4.1'.freeze | ||
| VERSION = '0.4.1' |
There was a problem hiding this comment.
Let's bump the version here to 0.4.2 🙂
| @@ -60,7 +60,7 @@ def all_descendants_with_methods | |||
| def search_descendants_matching_query | |||
| faker_descendants.each do |faker| | |||
| methods = faker.my_singleton_methods | |||
| matching = methods.select { |m| m.match?(/#{query}/i) } | |||
| matching = methods.select { |m| m.match(/#{query}/i) } | |||
kfpo
force-pushed
the
feature/support-search-ruby-less-than-2-4
branch
from
cc183a8
to
33b619c
Compare
|
Thank you for this gem! 🙂 |
|
Glad you found fakerbot useful and thank you for your contribution @kfpo ! 😄 Feel free to come back. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbol#matchbecause of missingSymbol#match?method in older Ruby versions( http://ruby-doc.org/core-2.3.7/Symbol.html#method-i-match ),
frozen_string_literal.What do you think, @akabiru ?