Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fakerbot list Command #2

Merged
merged 4 commits into from
Aug 10, 2018
Merged

Add fakerbot list Command #2

merged 4 commits into from
Aug 10, 2018

Conversation

akabiru
Copy link
Owner

@akabiru akabiru commented Aug 10, 2018 •
edited
Loading

Whats does this PR do

  • Adds a new command fakerbot list 🍾
  • Increase integration and unit test coverage
  • Adds a new release

@akabiru
chore(list): Make bot more high level
e583c32 
`FakerBot::Bot` knew too much about `search`; it should only perform
"bot ops" related to Faker Reflections and expose methods that commands
can access to retrieve what they need
@akabiru
feat(list): Add list command 😋
4efd14a
@akabiru
chore(list): Add unit and integration specs
cfc9ef4
@akabiru
chore(ad lid): More tests!
f9c9840
@coveralls
Copy link

Pull Request Test Coverage Report for Build 28

  • 61 of 61 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 25: 0.0%
Covered Lines: 72
Relevant Lines: 72
💛 - Coveralls

@akabiru akabiru merged commit a8609a3 into master Aug 10, 2018
@akabiru akabiru deleted the feature/list branch August 10, 2018 13:33
@akabiru akabiru self-assigned this Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@akabiru akabiru

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akabiru @coveralls