Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute Faker::Reflector Responsibilities #22

Merged
merged 4 commits into from
Jan 21, 2019

Conversation

akabiru
Copy link
Owner

@akabiru akabiru commented Jan 21, 2019

Description

The Reflector was a bit too crowded with responsibilities which made it quite hard to follow esp after coming back to the code after a while.

We can split the Reflector by responsibilities:

1.) Search reflector
2.) List reflector

and define an abstract interface that defines the makeup of a reflector.

The Reflector was a bit crowded with responsibilities which made it
quite hard to follow esp after coming back to the code after a while.
lib/fakerbot/reflectors/search.rb Outdated Show resolved Hide resolved
lib/fakerbot/reflectors/search.rb Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jan 21, 2019

Pull Request Test Coverage Report for Build 95

  • 41 of 41 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 96.059%

Totals Coverage Status
Change from base Build 89: 0.7%
Covered Lines: 195
Relevant Lines: 203

💛 - Coveralls

@akabiru akabiru changed the title Delegate Faker::Reflector Responsibilities Distribute Faker::Reflector Responsibilities Jan 21, 2019
@codeclimate
Copy link

codeclimate bot commented Jan 21, 2019

Code Climate has analyzed commit 0d095e9 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 100.0% (70% is the threshold).

This pull request will bring the total coverage in the repository to 96.0% (0.7% change).

View more on Code Climate.

@akabiru akabiru merged commit e9f13c8 into master Jan 21, 2019
@akabiru akabiru deleted the chore/refactor-reflector branch January 21, 2019 14:09
@akabiru akabiru self-assigned this Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants