Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Rename from FakerBot to Faker::CLI #28

Merged
merged 2 commits into from
Jul 6, 2019
Merged

chore: Rename from FakerBot to Faker::CLI #28

merged 2 commits into from
Jul 6, 2019

Conversation

akabiru
Copy link
Owner

@akabiru akabiru commented Jul 6, 2019 •
edited
Loading

Description

Change namespace from FakerBot to Faker::CLI

@akabiru akabiru marked this pull request as ready for review July 6, 2019 18:18
@akabiru akabiru requested a review from vbrazo July 6, 2019 18:20
vbrazo
vbrazo approved these changes Jul 6, 2019
View reviewed changes
Copy link
Collaborator

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@vbrazo vbrazo merged commit ec6d4c7 into akabiru:master Jul 6, 2019
@akabiru akabiru deleted the chore/namespace-faker-cli branch July 7, 2019 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

Assignees

@akabiru akabiru

Labels
chores
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akabiru @vbrazo