Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minitest - Warning: nested repeat operator #1206

Closed
vbrazo opened this issue May 12, 2018 · 7 comments
Closed

Minitest - Warning: nested repeat operator #1206

vbrazo opened this issue May 12, 2018 · 7 comments

Comments

@vbrazo
Copy link
Member

vbrazo commented May 12, 2018

I'm getting two warnings when I run rake test in the master branch.

Could anybody fix these warnings please?

screen shot 2018-05-12 at 4 45 55 pm

@vbrazo vbrazo added the Warning label May 12, 2018
@aamarill
Copy link

Hello,

I am looking to make my first open source contribution. Is this a good issue to work on?

@vbrazo
Copy link
Member Author

vbrazo commented May 14, 2018

@aamarill sure, why not?

Feel free to fork the project to your profile and pull it to your computer. After that you can create a Pull Request and start committing there. Run bundle install to install the gems and run rake test to find the warnings. Once it's done, you can push and open a PR in our repository.

@aamarill
Copy link

Thank you @vbrazo I'll get on it ASAP

@vbrazo
Copy link
Member Author

vbrazo commented May 19, 2018

@aamarill I had free time and fixed the warnings today. I'm going to assign you another task, ok? 👍

@aamarill
Copy link

@vbrazo No worries!
I am actually pretty free now, so if you have any "newbie-friendly" issues available, send them my way!
🥂

@vbrazo vbrazo closed this as completed May 19, 2018
@vbrazo
Copy link
Member Author

vbrazo commented May 20, 2018

@aamarill You can filter the issues.

Here I'm filtering by Bug/Fixes. You could also filter by Feature Request, Documentation and others.

Go there, read the issues. I'm pretty sure that you'll find someone who needs help or an issue that is open just waiting for you. Message people. Make noise 👍

@aamarill
Copy link

@vbrazo Will do! Thanks!! 🥂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants