Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate celebrity methods in favor of actor #1760

Closed
connorshea opened this issue Sep 21, 2019 · 3 comments
Closed

Deprecate celebrity methods in favor of actor #1760

connorshea opened this issue Sep 21, 2019 · 3 comments

Comments

@connorshea
Copy link
Member

A lot of the TvShows/Movies fakers have an actor method, e.g. Ghostbusters, but two (Buffy and Fresh Prince) use celebrity instead.

We should rename them to actor and create a celebrity alias, then deprecate the celebrity method.

Also, Community has plural methods. Those should be changed to singular.
@connorshea
Copy link
Member Author

Oh, and for some reason Star Wars has plural methods that return all the options from a given faker. Is that intentional or are those supposed to be private?

@connorshea connorshea changed the title Deprecate celebrity methods in factor of actor Deprecate celebrity methods in favor of actor Sep 21, 2019
@mathisto
Copy link
Contributor

mathisto commented Oct 3, 2019

Not sure if the naming decisions were made based on the ambiguity of gender in actor/actress. Celebrity is neutral. Thoughts?

@vraravam vraravam mentioned this issue Oct 1, 2020
Merged
@Zeragamba
Copy link
Contributor

issue resolved in #2133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Zeragamba @connorshea @mathisto