Change of Random::DEFAULT -> Random.new is incorrect

[Qqwy]

The merged PR #2225 replaced Random::DEFAULT (which is deprecated in Ruby 3) with Random.new.

faker/lib/faker.rb

Line 32 in b78a47e

@random || Random.new

See #2225 (comment)

However, this is incorrect, and it breaks any test suite which expects reproducible results by seeding the global RNG when a seed argument is used.

The fix is to use Random (the class) instead of Random.new, as this is the new place where the 'global' RNG lives (and indeed Random::DEFAULT refers to Random in Ruby 3).

See the two bullet points under 'Random' in the Ruby 3.0.0 release notes for more info.

[Qqwy]

It might very well be necessary to add conditional code based on whether we're on Ruby 1, 2 or 3 to work correctly on all Ruby versions.

[connorshea]

I've merged the fix to master, thanks for pointing this out! And sorry for introducing this problem in the first place 🙈

[Qqwy]

Thank you for fixing this in a timely manner! 😄