Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build not possible without pdf of infographic #143

Open
katkolouchova opened this issue Jan 6, 2022 · 2 comments
Open

Build not possible without pdf of infographic #143

katkolouchova opened this issue Jan 6, 2022 · 2 comments
Labels
1: low priority Not importantn now, nice-to-have

Comments

@katkolouchova
Copy link
Member

It would be useful to be able to generate a preview without having to upload pdf of infographic (in case the text is finished first). Or to return a better error message of why the build failed.

@katkolouchova katkolouchova added the 1: low priority Not importantn now, nice-to-have label Jan 6, 2022
@mukrop
Copy link
Member

mukrop commented Jan 7, 2022

Well, depends.

The point of tests is to check that all linked media exists (apart from checking other things). Allowing build without the infographic would mean having an exception to this rule (i.e. effectively not checking if the infographic was uploaded or not).

Though, on the other side, I understand that uploading a placeholder effectively renders that check useless as well :-/.

What do you think? Any opinions from @mgrabovsky?

@mgrabovsky
Copy link
Member

I agree that it would be a useful feature to have. Sometimes, we might just want to check what the text looks like on the page without having to export the infographic or running the build locally.

Alternatively, can we just disable the link checks for preview branches and only require them for merging pull requests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: low priority Not importantn now, nice-to-have
Projects
None yet
Development

No branches or pull requests

3 participants