-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics are not created if http_output is enabled #2645
Comments
Thanks for reporting this Anna and help us iron out these things to be able to get the metrics feature into a stable state for the next Falco release. We will look into it, thanks for your patience! |
Hey @annadorottya can you share Falco startup logs? Just in case there is any warning :) |
Hi @FedeDP ,
|
I am not able to repro locally unfortunately; but can repro with:
They both just show 2 messages and then stop:
This makes me think that the issue lies somewhere in the build toolchain (ie: gcc version used in our CI) and in this logic: https://github.com/falcosecurity/falco/blob/master/userspace/falco/stats_writer.cpp#L150 (perhaps the I will push some debug printf to trigger a build from CI and then i'll try to understand what's going on :) This seems a subtle but very funny bug, thank you for reporting it! |
Ok i was able to fix the issue by switching to |
Falco 0.35.1 is out and should've fixed this issue! @annadorottya care to test? Thank you! |
I tested it and it works! Thank you for the quick fix! |
Thanks to you for reporting the issue! :) |
Describe the bug
If
http_output
is enabled, then only one metric alert is created / only one line is written in the metrics log file regardless the set period.How to reproduce it
Set config to:
Expected behaviour
Metrics alerts are created every minute and written to the
/tmp/falco_stats.jsonl
file every minute.Screenshots
Environment
Additional context
Thread on kubernetes slack workspace: https://kubernetes.slack.com/archives/CMWH3EH32/p1686643450242449
@incertum @Issif @alacuku @jasondellaluce
The text was updated successfully, but these errors were encountered: