Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: segfault on hot reload of configs in current falco master #3188

Closed
incertum opened this issue May 8, 2024 · 5 comments · Fixed by #3190
Closed

Bug: segfault on hot reload of configs in current falco master #3188

incertum opened this issue May 8, 2024 · 5 comments · Fixed by #3190
Assignees
Labels
Milestone

Comments

@incertum
Copy link
Contributor

incertum commented May 8, 2024

When hot reloading a Falco rules file, Falco segfaults while actually reloading the config file aka at the very beginning of the (re-)init phase.

Thread 3 "falco" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffefe006c0 (LWP 119895)]
yaml_helper::load_from_file (path="../falco.yaml", this=0x390)
    at /falco/userspace/falco/yaml_helper.h:97
97			m_root = load_from_file_int(path);
Missing separate debuginfos, use: dnf debuginfo-install elfutils-libelf-0.191-2.fc39.x86_64 glibc-2.38-16.fc39.x86_64 libcap-2.48-9.fc39.x86_64 libstdc++-13.2.1-6.fc39.x86_64 sssd-client-2.9.4-1.fc39.x86_64 systemd-libs-254.10-1.fc39.x86_64 zlib-1.2.13-4.fc39.x86_64
(gdb) 

To repro just run current Falco master and then modify and save a rules file that was initially loaded.

Note: I tested it with tag 0.37.1 and there were no issues, therefore the bug was recently introduced.
@FedeDP mind helping? Thanks!

This bug is blocking the following PR: #3187

@incertum incertum added this to the 0.38.0 milestone May 8, 2024
@FedeDP
Copy link
Contributor

FedeDP commented May 8, 2024

I will check it and report back, hopefully with a fix :D

@FedeDP
Copy link
Contributor

FedeDP commented May 8, 2024

/assign

@FedeDP
Copy link
Contributor

FedeDP commented May 9, 2024

So, the issue is caused by #3184 .
Digging deeper to look for a fix!

@FedeDP
Copy link
Contributor

FedeDP commented May 9, 2024

Opened the fix: #3190

@FedeDP
Copy link
Contributor

FedeDP commented May 9, 2024

Also added a test to the testing framework for hot reload: falcosecurity/testing#54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants