Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Falcosidekick outout KAFKA with TLS support #547

Closed
victorrodriguez1984 opened this issue Jul 6, 2023 · 4 comments
Closed

Falcosidekick outout KAFKA with TLS support #547

victorrodriguez1984 opened this issue Jul 6, 2023 · 4 comments
Labels
kind/feature New feature or request
Milestone

Comments

@victorrodriguez1984
Copy link

Motivation

Feature

Alternatives

@victorrodriguez1984 victorrodriguez1984 added the kind/feature New feature or request label Jul 6, 2023
@Issif Issif added this to the 2.28.0 milestone Jul 6, 2023
@Issif
Copy link
Member

Issif commented Jul 7, 2023

Have you tested this config?

kafka:
  hostport: "ssl://<address>:9092"

Technically, it should work.

@Issif
Copy link
Member

Issif commented Jul 11, 2023

@victorrodriguez1984 can you try my proposal to check if it's ok please?

@Issif Issif modified the milestones: 2.28.0, 2.29.0 Jul 12, 2023
@ibice
Copy link
Contributor

ibice commented Jul 26, 2023

Hi @Issif, @victorrodriguez1984 and me have tested your proposal, but it seems it doesn't like it. It tries to resolve ssl://<address>:<port>. Here's the error message:

dial tcp: lookup ssl://server:9092: no such host

To see the error, I had to modify the code to handle this returned err:

// Errors are logged/captured via handleKafkaCompletion function, ignore here
_ = c.KafkaProducer.WriteMessages(context.Background(), kafkaMsg)

It might be worth handling it, it seems handleKafkaCompletion captures errors during async writes and WriteMessages returns synchronous errors. What do you think?

@Issif Issif moved this from To do to Done in Falcosidekick 2.x Aug 7, 2023
@Issif Issif modified the milestones: 2.29.0, 2.28.0 Aug 7, 2023
@Issif
Copy link
Member

Issif commented Aug 7, 2023

Everything is available with release 2.28.0 👍

@Issif Issif closed this as completed Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants