Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required FFmpeg version #1403

Closed
minijackson opened this issue Apr 28, 2021 · 4 comments
Closed

Update required FFmpeg version #1403

minijackson opened this issue Apr 28, 2021 · 4 comments

Comments

@minijackson
Copy link

Hello! I maintain Carla over on the NixOS Linux distribution, and we're trying to migrate away from ffmpeg <= 3.x, due to several vulnerabilities (see NixOS/nixpkgs#94003 and NixOS/nixpkgs#120372).

I looked at the Makefile and saw that Carla requires ffmpeg v2.8.15 maximum, which felt weird to me, since currently on NixOS it is packaged with ffmpeg 3.4.8. I'm not sure how those pkg-config commands didn't fail.

Carla builds fine with ffmpeg 3.4.8 and ffmpeg 4.3.2, but I'm not sure where the ffmpeg decoder is used. I tried using the Audio file internal plugin, but couldn't hear anything, I'm not sure if this is a user error or an issue with our build, but Carla didn't crash with ffmpeg 4.3.2.

Do you think it would be possible to upgrade the required ffmpeg version? Or should we ship Carla without ffmpeg support?

Thanks for the great work!

@falkTX
Copy link
Owner

falkTX commented Apr 28, 2021

Just dont use ffmpeg. that part is legacy code.
At some point I am going to update it, but didnt bother with it yet. the main use was for mp3 support but there is a different/new library built-in carla for that now.

@minijackson
Copy link
Author

minijackson commented Apr 28, 2021

Got it, thanks! Should I leave the issue opened?

@falkTX
Copy link
Owner

falkTX commented Apr 28, 2021

depends on how much you care to see this (re)added.
it is not a priority for me at all, likely for many months

@minijackson
Copy link
Author

I'll close this then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants