Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jellyfinlogin): add proper error message when no admin user exists #1216

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

gauthier-th
Copy link
Collaborator

Description

This PR adds an error message when the database has no admin user and Jellyseerr has already been set up (i.e. settings.json is filled in), instead of having a generic error message.

Screenshot (if UI-related)

Before:
image

After:
image

To-Dos

  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

This PR adds an error message when the database has no admin user and Jellyseerr has already been
set up (i.e. settings.json is filled in), instead of having a generic error message.
@gauthier-th gauthier-th merged commit ac90802 into develop Jan 2, 2025
6 checks passed
@gauthier-th gauthier-th deleted the fix-noadmin-error branch January 2, 2025 15:03
@fallenbagel
Copy link
Owner

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants