-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chapter 5 becoming obsolete :-( #70
Comments
Hi! You can find an experimental version here: https://github.com/MarcusFra/beginners-pytorch-deep-learning/blob/chapter5_new_api/chapter5/Chapter_5_new_api__temp.ipynb Please note, that it's the same dataset, but a different model used (without LSTM). There are also some issues left in the data preparation stage, like padding etc. I am going to change those parts to make it similar to the example in the book. |
Thank you very much for your answer and for you help. Learning torchtext isn't easy because it's growing bigger every day... |
You are welcome, I am going to leave a message here once the final version is pushed. |
The book is very helpful, looking forward to the updated codes with pytorch 2.0 and lastest torchtext (0.15.0). Many thanks! |
Hi @ccshao, I had a look again on this (I already took a look at this in April where the solutions appeared not to be stable yet). I will keep an eye on the changes in the use of datapipes and dataloaders and hope to publish a final stable solution for pytorch > 2.x by the end of this year regarding torchtext. For now please refer to the legacy solution or the experimental solution by me mentioned earlier in this issue. Another possibility would be to use the Huggingface library instead of torchtext. |
New features brought to torchtext are making the code obsolete (fields, dictionaries etc). You can still run the code for a little bit, using modified imports (from torchtext.legacy import data). Are you going to update the code for the 5th chapter, or is the job too long? Will we have an updated version of the book? thanks in advance.
The text was updated successfully, but these errors were encountered: