Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New AFTER_LOGIN trigger #92

Open
alexazevedo opened this issue Mar 25, 2019 · 1 comment
Open

New AFTER_LOGIN trigger #92

alexazevedo opened this issue Mar 25, 2019 · 1 comment

Comments

@alexazevedo
Copy link

Hello!
Thank you for all your hard work on this plugin. We are integrating it with Okta and it works really well!
So, we need want to rely only on the SAML service for user authorization (getting user groups from Okta and creating a custom Authentication backend for this). One of the ideas that we have is to store the user group in the session and then recover it inside a middleware or a custom Authentication backend. To do that we might want to have a different trigger that is fired after login. We tried to use the built in "BEFORE_LOGIN" but it doesn't work for us, since you flush the session right before call the login function in the acs view on views.py.

What do you think about having a AFTER_LOGIN trigger, that is fired right after the the login, if it's successful ?

@alexazevedo
Copy link
Author

I've just implemented these changes in this PR: #93
Could guys please check it out and give your thoughts?

@alexazevedo alexazevedo changed the title New POST LOGIN trigger New AFTER_LOGIN trigger Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant